src/db.rs (1)

3410-3416: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add a positive-path migration test.

With rebuild_disputes_table_preserves_rows gone, the only remaining coverage is the no-op branch — the actual drop path (and row preservation) is untested. A test that adds the legacy columns back, inserts a row, runs the migration, and asserts both columns are gone while the row survives would keep coverage on the reachable logic this PR is consolidating onto.

🧪 Sketch of the missing test

#[tokio::test]
async fn migrate_remove_token_columns_drops_legacy_columns_and_preserves_rows() {
    let pool = migrated_pool().await;
    sqlx::query("ALTER TABLE disputes ADD COLUMN buyer_token INTEGER")
        .execute(&pool)
        .await
        .unwrap();
    sqlx::query("ALTER TABLE disputes ADD COLUMN seller_token INTEGER")
        .execute(&pool)
        .await
        .unwrap();
    // insert a dispute row here, then:
    migrate_remove_token_columns(&pool).await.unwrap();
    assert!(!table_column_exists(&pool, "disputes", "buyer_token").await.unwrap());
    assert!(!table_column_exists(&pool, "disputes", "seller_token").await.unwrap());
    // assert the inserted row is still present
}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/db.rs` around lines 3410 - 3416, Add a positive-path test alongside
migrate_remove_token_columns_is_noop_without_token_columns that restores both
legacy token columns, inserts a disputes row, runs migrate_remove_token_columns,
and verifies buyer_token and seller_token are removed while the inserted row
remains.